-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: fix tests #14720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix tests #14720
Conversation
Package Changes Through 478d611There are 7 changes which include tauri-utils with patch, tauri-build with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch, tauri-runtime with patch, tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| [dev-dependencies] | ||
| getrandom = { version = "0.3", features = ["std"] } | ||
| serial_test = "3" | ||
| tauri = { path = "../tauri" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause any problems because of the circular dependency? Looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a dev dependency I don't think so? Or rather I hope so. Couldn't spot any issues but now I'm unsure x)
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does the mobile app always send comments twice 😡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could always revert if we find any problems with it, so YOLO I guess
| [dev-dependencies] | ||
| getrandom = { version = "0.3", features = ["std"] } | ||
| serial_test = "3" | ||
| tauri = { path = "../tauri" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could always revert if we find any problems with it, so YOLO I guess
./path differently #14662tests/restartdoesn't work with the new cargo build diralso fixes #14719